[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Add firmware configuration for MAX98373_ALC5682I_I...

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44560 )

Change subject: mb/google/volteer: Add firmware configuration for MAX98373_ALC5682I_I2S_UP4
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44560/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/fw_config.c:

https://review.coreboot.org/c/coreboot/+/44560/4/src/mainboard/google/voltee... 
PS4, Line 96: dmic_enable_pads
> Are dmic gpios the same for UP3 and UP4?

In Halvor:
The GPP_S4(SOC_DMIC_CLK1) and GPP_S5(SOC_DMIC_DATA1) are preserved for DMIC1.
The GPP_S6(SOC_DMIC_CLK0) and GPP_S7(SOC_DMIC_DATA0) are used for DMIC0.
All of them are NF2.