Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Krishna P Bhat D. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61141 )
Change subject: mb/google/nissa: Add devicetree ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/61141/comment/31ed50be_043ab042 PS5, Line 120: i2c0 Can we add the tpm driver here? I think the only reason brya has it in the variants is that some variants use I2C1 and some I2C3. But on nissa they should all use I2C0 (for now at least).
https://review.coreboot.org/c/coreboot/+/61141/comment/3783b876_59960db7 PS5, Line 123: pcie_rp7 Are we supporting RTD3 on the SD card, and if so should we add the RTD3 driver here? On brya, the SD card RP is enabled in the baseboard, but the RTD3 driver is added individually in each variant. I'm not sure if there's a reason not to do both in the baseboard.