Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43408 )
Change subject: soc/amd/picasso: add dptc support ......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43408/16/src/soc/amd/picasso/root_c... File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/43408/16/src/soc/amd/picasso/root_c... PS16, Line 195: dptci_setup();
I think we don't really need this if dptc_enable is not true? Just bail out early: […]
Done
https://review.coreboot.org/c/coreboot/+/43408/16/src/soc/amd/picasso/root_c... PS16, Line 205: dptci_update_parameter(DPTC_FAST_PPT_LIMIT, config->dptc_fast_ppt_limit); : dptci_update_parameter(DPTC_SLOW_PPT_LIMIT, config->dptc_slow_ppt_limit); : dptci_update_parameter(DPTC_SUSTAINED_POWER_LIMIT, : config->dptc_sustained_power_limit);
Why are we making 3 separate calls to ALIB? As per the spec it looks like ALIB allows multiple param […]
Done