[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Set correct serirq mode based on SERIRQ_CONTINU...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31536 )

Change subject: soc/intel/cannonlake: Set correct serirq mode based on SERIRQ_CONTINUOUS_MODE
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31536/2/src/soc/intel/cannonlake/fsp_params.... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/31536/2/src/soc/intel/cannonlake/fsp_params.... 
PS2, Line 250: 	/* Set correct Sirq mode based on config */
> For once, I wouldn't say that. FSP is full of these […]

Subrata, what do you think about the Kconfig vs.
`chip.h` setting? If we agree to use Kconfig for
this, I can write a patch that removes the `chip.h`
entry in skylake/.