build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )
Change subject: sc7180: Add display dsi interface programming [Patch 2 of 3] ......................................................................
Patch Set 13:
(25 comments)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 62: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 178: wmb(); memory barrier without comment
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 186: wmb(); memory barrier without comment
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 189: wmb(); memory barrier without comment
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 196: wmb(); memory barrier without comment
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 199: wmb(); memory barrier without comment
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 350: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 353: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 356: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 359: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 362: setbits32(&dsi0->int_ctrl,DSI_BTA_DONE_AK); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 364: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 371: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 627: void mdss_dsi_clock_config() Bad function definition - void mdss_dsi_clock_config() should probably be void mdss_dsi_clock_config(void)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/di... PS13, Line 630: write32(&dsi0->clk_ctrl,0); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/display/mipi_dsi.h:
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 25: #define MIPI_DSI_REG_LEN 16 /* 4 x 4 bytes register */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 31: #define DSI_VIDEO_DST_FORMAT_RGB565 0 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 32: #define DSI_VIDEO_DST_FORMAT_RGB666 1 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 34: #define DSI_VIDEO_DST_FORMAT_RGB888 3 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 35: #define DSI_CMD_DST_FORMAT_RGB111 0 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 36: #define DSI_CMD_DST_FORMAT_RGB332 3 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 37: #define DSI_CMD_DST_FORMAT_RGB444 4 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 38: #define DSI_CMD_DST_FORMAT_RGB565 6 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 39: #define DSI_CMD_DST_FORMAT_RGB666 7 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39614/13/src/soc/qualcomm/sc7180/in... PS13, Line 40: #define DSI_CMD_DST_FORMAT_RGB888 8 please, no space before tabs