build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34337 )
Change subject: soc/intel/common: add advanced macros for gpio config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34337/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/34337/1/src/soc/intel/common/block/...
PS1, Line 417: #define PAD_CFG0_BUF_BOTH_DIS PAD_CFG0_TX_DISABLE | PAD_CFG0_RX_DISABLE
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9fe50ff9a680633db6228564345200c0e1ee3ea
Gerrit-Change-Number: 34337
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 14 Jul 2019 18:58:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment