Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42339 )
Change subject: soc/amd/picasso: fix build if PICASSO_UART is unset
......................................................................
Patch Set 4: Code-Review+2
Patch Set 3:
Well, how about at least
smm-$(CONFIG_DEBUG_SMI) += uart.c
That's already in there
Oh sorry. I thought I'd already changed smm-$() to CONFIG_PICASSO_UART here. But you're right, it's correct as it is now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42339
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1173034b0d2ed32f77241768e1e8abb208aac3a
Gerrit-Change-Number: 42339
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 13:20:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment