Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39448 )
Change subject: soc/intel/cannonlake: Add configs for USB 3.1 Gen2 EV settings ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39448/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39448/1//COMMIT_MSG@7 PS1, Line 7: strength
Add configs for USB 3. […]
Done
https://review.coreboot.org/c/coreboot/+/39448/1//COMMIT_MSG@9 PS1, Line 9: Add usb configs for tuning USB3.1 Gen2 strength.
Add configs for USB 3. […]
Done
https://review.coreboot.org/c/coreboot/+/39448/1//COMMIT_MSG@13 PS1, Line 13: successful in puff
did you verify the settings are set accordingly by FSP log?
Yes, I verified the fsp log. All usb settings are correct.