[coreboot-gerrit] Change in ...coreboot[master]: Makefile.inc: Compile smm files based on CONFIG_BUILD_SMM

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33115 )

Change subject: Makefile.inc: Compile smm files based on CONFIG_BUILD_SMM
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33115/5/src/arch/x86/Makefile.inc 
File src/arch/x86/Makefile.inc:

https://review.coreboot.org/#/c/33115/5/src/arch/x86/Makefile.inc@403 
PS5, Line 403: CONFIG_BUILD_SMM
> Same thing as all my other comments. […]

isn't the case that we need to compile smm code for x86 platform ?

Also few files like uart.c, smihandler.c are getting compiled inside smm mode as well. Those files might need to perform memset, memcpy, those functions are part of files that been compiled here inside this Makefile.inc.

I thought this CL is simple where we might just need to compile smm code outside ramstage independently.