mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47261 )
Change subject: sc7180: Correct mmu configuration for AOP SRAM regions ......................................................................
Patch Set 1:
(2 comments)
Next commit (shortly) addresses these two comments.
https://review.coreboot.org/c/coreboot/+/47261/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47261/1//COMMIT_MSG@8 PS1, Line 8:
Please add a few sentences here explaining what the problem was and why this fixes it.
Ack
https://review.coreboot.org/c/coreboot/+/47261/1/src/soc/qualcomm/sc7180/mmu... File src/soc/qualcomm/sc7180/mmu.c:
https://review.coreboot.org/c/coreboot/+/47261/1/src/soc/qualcomm/sc7180/mmu... PS1, Line 26: mmu_config_range((void *)_aop_dec, REGION_SIZE(aop_dec), DEV_MEM);
We really don't need all these tiny ones. […]
Ack