[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Add function to wait for CSE to enter Soft Temp Dis...

[Sridhar Siricilla (Code Review)]

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36786 )

Change subject: soc/intel/common: Add function to wait for CSE to enter Soft Temp Disable mode
......................................................................

Patch Set 39:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36786/16/src/soc/intel/common/block... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/36786/16/src/soc/intel/common/block... 
PS16, Line 317: uint8_t
> Since the function return 0 or 1, so uint8_t as return type.

Done

https://review.coreboot.org/c/coreboot/+/36786/36/src/soc/intel/common/block... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/36786/36/src/soc/intel/common/block... 
PS36, Line 314: HECI_DELAY_READY
> 15 seconds(HECI_DELAY_READY) is not right timeout in this context. […]

Done

https://review.coreboot.org/c/coreboot/+/36786/36/src/soc/intel/common/block... 
File src/soc/intel/common/block/include/intelblocks/cse.h:

https://review.coreboot.org/c/coreboot/+/36786/36/src/soc/intel/common/block... 
PS36, Line 200: cse_wait_com_soft_temp_disable
> The usage as you suggested can be seen in  https://review.coreboot. […]

Done