Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/28351 )
Change subject: vendorcode/facebook: Add vendorcode ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/Kconfig File src/vendorcode/facebook/Kconfig:
https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/Kconfig@27 PS1, Line 27: "Enables TIVA hard reset feature" are you sure you don't want this in help instead of bool? Is this something you want to be able to select in menuconfig?
https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/opencellular... File src/vendorcode/facebook/opencellular/reset.c:
https://review.coreboot.org/#/c/28351/1/src/vendorcode/facebook/opencellular... PS1, Line 20: void do_hard_reset(void) : { : } Should it have an empty body?