Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31368 )
Change subject: soc/intel/skylake: Avoid TOL_1V8 being set for GPP_F4 ~ GPP_F11 ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/31368/6/src/soc/intel/common/block/gpio/gpio... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/#/c/31368/6/src/soc/intel/common/block/gpio/gpio... PS6, Line 276: #if IS_ENABLED(CONFIG_SOC_INTEL_SKYLAKE) && \ are the preprocessor checks required ?