Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42797 )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... PS1, Line 135: // data &= mask; : // if (smi1) : // southbridge_smi_command(data); : // return;
How about dropping everything instead?
I do not know. I can do that in a follow-up. Then whoever looks at the code, and wants to revert it, can resurrect the correct code.