Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45789 )
Change subject: soc/intel: Move pch_misc_init() to common code ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45789/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45789/7//COMMIT_MSG@10 PS7, Line 10: refer from block/lpc directory.
This patch is a bit large... What I would do is combine CB:45787 and this, then split it into one patch per function:
soc/intel: Move `pch_enable_ioapic` to common code
https://review.coreboot.org/c/coreboot/+/45787/7
soc/intel: Move `pch_pirq_init` to common code
https://review.coreboot.org/c/coreboot/+/45809/1
soc/intel: Move `pch_misc_init` to common code
https://review.coreboot.org/c/coreboot/+/45789
This would result in slightly smaller patches. Also, it would be easier to review, as the common code would be in the same patch as the per-SoC removals. What do you think?
yes, already done. thanks