Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37247 )
Change subject: mb/google/octopus: Create Lick variant
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37247/10/src/mainboard/google/octop...
File src/mainboard/google/octopus/variants/lick/gpio.c:
https://review.coreboot.org/c/coreboot/+/37247/10/src/mainboard/google/octop...
PS10, Line 38: DISPUPD),
Nit: this, and the one on the next line, can go on the previous line (max line length is 96 characters)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If732d94194defb9f5ee9c847ee93dd58aef01174
Gerrit-Change-Number: 37247
Gerrit-PatchSet: 10
Gerrit-Owner: Hash Hung
hash1.hung@lcfc.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hash Hung
hash1.hung@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Regan Chang
regan.chang@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Sat, 30 Nov 2019 16:04:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment