1 Apr
2020
1 Apr
'20
2:36 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40010 )
Change subject: sb/intel/bd82x6x/sata: Fix IDE legacy mode, plus more ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/sata.c:
https://review.coreboot.org/c/coreboot/+/40010/1/src/southbridge/intel/bd82x... PS1, Line 189: reg16 = pci_read_config16(dev, PCI_COMMAND); : reg16 &= ~PCI_COMMAND_MEMORY; : pci_write_config16(dev, PCI_COMMAND, reg16); I wonder if this is a no-op, why should we have set the MEMORY bit?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b078d7790ca801a89066ef6a161d900be5eb778
Gerrit-Change-Number: 40010
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 Apr 2020 09:36:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment