[coreboot-gerrit] Change in coreboot[master]: sb/intel: Declare acpi_disable_sci_on_exit()

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36828 )

Change subject: sb/intel: Declare acpi_disable_sci_on_exit()
......................................................................

Patch Set 12: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/36828/12/src/include/cpu/x86/smm.h 
File src/include/cpu/x86/smm.h:

https://review.coreboot.org/c/coreboot/+/36828/12/src/include/cpu/x86/smm.h@... 
PS12, Line 56: }
> !acpi_is_wakeup_s3() && CONFIG(HAVE_SMI_HADLER)

OR flip the operands to take advantage of short-circuit evaluation:

CONFIG(HAVE_SMI_HADLER) && !acpi_is_wakeup_s3()

Since `CONFIG(HAVE_SMI_HADLER)` is a compile-time constant, if it's false, then the `acpi_is_wakeup_s3()` call can be optimized out.