8 Jun
2020
8 Jun
'20
10:17 a.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41922 )
Change subject: sb/intel/i82801ix: Select COMMON_FADT ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41922/5/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/fadt.c:
https://review.coreboot.org/c/coreboot/+/41922/5/src/southbridge/intel/i8280... PS5, Line 13: fadt->preferred_pm_profile = PM_MOBILE; isn't this already done #if CONFIG(COMMON_FADT) here src/acpi/acpi.c (line 1257) ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/41922
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffdce450b1d4c9984ec5efe11eff62bf9184e314
Gerrit-Change-Number: 41922
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jun 2020 16:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment