Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29644 )
Change subject: mainboard/google/octopus/variants/ampton: I2C touchpad and touch-panel tuning ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/29644/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29644/3//COMMIT_MSG@17 PS3, Line 17: Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0 You will need a "Signed-off-by" line
https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/ampton/overridetree.cb:
https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variant... PS3, Line 8: .i2c[0] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 152, : .fall_time_ns = 30, : }, Does i2c0 frequency look fine?
https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/variant... PS3, Line 13: .i2c[5] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 104, : .fall_time_ns = 52, : }, Does this look fine?