Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35344 )
Change subject: mb/google/hatch: Merge emmc_sku_gpio_table and gpio_table to one table
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35344/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/35344/1/src/mainboard/google/hatch/...
PS1, Line 173: if (sku_id == 1) {
Hi Peichao, Furquan reminded you that your line 174, 175 are the same with 177,178, right? As a resu […]
Yes, it is same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c0adf569cc92e8b44ab72379420f2b190fa31f5
Gerrit-Change-Number: 35344
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Justin TerAvest
teravest@google.com
Gerrit-CC: Philip Chen
philipchen@google.com
Gerrit-Comment-Date: Wed, 11 Sep 2019 07:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment