Attention is currently required from: Alexander Couzens, Angel Pons, Keith Hui, Martin L Roth.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76962?usp=email )
Change subject: SNB+MRC boards: Do not redo PEI data struct in hook
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/mainboard/roda/rv11/variants/rw11/early_init.c:
https://review.coreboot.org/c/coreboot/+/76962/comment/68669b63_12f4520e :
PS5, Line 64: pcie_init
set by northbridge_fill_pei_data?
https://review.coreboot.org/c/coreboot/+/76962/comment/13520015_1e539efa :
PS5, Line 65: usb3
Use devicetree setting register "usb3.mode"= ...?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76962?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie349a8f400eecca3cdbc196ea0790aebe0549e39
Gerrit-Change-Number: 76962
Gerrit-PatchSet: 5
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Tue, 10 Oct 2023 18:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment