Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38985 )
Change subject: WIP: skylake-sp: Add uncore and memory map
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38985/10/src/cpu/intel/xeonsp/cpu/s...
File src/cpu/intel/xeonsp/cpu/skylake-sp/include/soc/skx_iomap.h:
https://review.coreboot.org/c/coreboot/+/38985/10/src/cpu/intel/xeonsp/cpu/s...
PS10, Line 20: 0x6a7a9000
Are these magic numbers configurable?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3cb271a974f06d24ff17987595b700e7bdadc47
Gerrit-Change-Number: 38985
Gerrit-PatchSet: 10
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 24 Feb 2020 15:53:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment