Attention is currently required from: Jean Lucas, Nicholas Chin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81861?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: nb/intel/gm45: Fill in memory info ......................................................................
Patch Set 1:
(2 comments)
File src/northbridge/intel/gm45/raminit_meminfo.c:
https://review.coreboot.org/c/coreboot/+/81861/comment/0540bcd7_2b6d9f11 : PS1, Line 61: FOR_EACH_POPULATED_RANK This is wrong, dual-rank DIMMs end up with two entries
https://review.coreboot.org/c/coreboot/+/81861/comment/c9b1b780_0fe62767 : PS1, Line 83: mem_info->number_of_devices = 2;
Is this like the number of slots? Just curious.
Yes, that should be the number of DIMMs