[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add chip config to override CPU flex ratio

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36864 )

Change subject: soc/intel/cannonlake: Add chip config to override CPU flex ratio
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36864/2/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/36864/2/src/soc/intel/cannonlake/ro... 
PS2, Line 80: if (CONFIG(OVERRIDE_CPU_FLEX_RATIO))
> we could do that for sure but trying to leverage more from existing setting without writing code into CB.

In older code the flex ratio is set based on other MSR's, MSR_CONFIG_TDP_NOMINAL. Can the same not be done here too? Having yet another Kconfig/devicetree value should be avoided especially since it is hardly mainboard specific.