Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46614 )
Change subject: mb/google/octopus/var/fleex: Add goodix touch pad support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46614/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46614/1//COMMIT_MSG@11
PS1, Line 11: CID:PNP0C50
: I2C address:0x2C
: I2C speed:400Khz
: HID Descriptor Address:0x20
Please add a space after the colons.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb4f8d3aff09712dcc98c8ae0c9ae30dc4049e29
Gerrit-Change-Number: 46614
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 10:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment