Attention is currently required from: Alicja Michalska, Arthur Heymans, Christian Walter, David Hendricks, Intel coreboot Reviewers, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Paul Menzel, Tim Chu, Vasiliy Khoruzhick, yuchi.chen@intel.com.
Felix Held has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email )
Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/86131/comment/7cfbe57f_eaea9c0d?usp... :
PS9, Line 1019: Required for modern graphics cards, such as Intel Arc.
Not sure what else to add, any suggestions?
maybe mention that some GPUs need very large prefetchable BARs which don't fit below 4GB, so those need to be allocated above the 4GB boundary
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5
Gerrit-Change-Number: 86131
Gerrit-PatchSet: 12
Gerrit-Owner: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 09 Apr 2025 17:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Alicja Michalska
ahplka19@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org