Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45847 )
Change subject: soc/intel/xeon_sp: Add get_system_memory_map()
......................................................................
Patch Set 5: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/45847/5/src/soc/intel/xeon_sp/skx/s...
File src/soc/intel/xeon_sp/skx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/45847/5/src/soc/intel/xeon_sp/skx/s...
PS5, Line 383: fsp_find_extension_hob_by_guid
This seems to return a `struct SystemMemoryMapHob *` for SKX.
Yes, The HOB data access is different between the SKX and CPX FSP. Since this is split out already, we can do the correct access here. We will just need to be careful in the de-duplication.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54675b52aaf2999d884b3c20ccb143fbbf8b138a
Gerrit-Change-Number: 45847
Gerrit-PatchSet: 5
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Oct 2020 20:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment