Rishabh Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33425 )
Change subject: qcs405: Add support for specifying mbn_version
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33425/2/util/qualcomm/mbn_tools.py
File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/#/c/33425/2/util/qualcomm/mbn_tools.py@73
PS2, Line 73: MI_BOOT_IMG_HDR_SIZE_v6 = 48 # sizeof(mi_boot_image_header_type) for v6 header
Done
I will create a function but I will not remove these contants because I dont know weather some older chipsets are using this constants from mbn_tool after import
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6e269e0f290692871875000586410217c25fc08
Gerrit-Change-Number: 33425
Gerrit-PatchSet: 2
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Rishabh Sharma
rishabh435@gmail.com
Gerrit-Comment-Date: Wed, 26 Jun 2019 05:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Rishabh Sharma
rishabh435@gmail.com
Gerrit-MessageType: comment