Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32283 )
Change subject: soc/intel/../../timer: Calculate TSC frequency based on CPUID 0x15 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32283/2/src/soc/intel/common/block/timer/tim... File src/soc/intel/common/block/timer/timer.c:
https://review.coreboot.org/#/c/32283/2/src/soc/intel/common/block/timer/tim... PS2, Line 26: struct
does this require __packed to make sure the bitfield isn't laid out in 7 words or something crazy li […]
Done
https://review.coreboot.org/#/c/32283/2/src/soc/intel/common/block/timer/tim... PS2, Line 81: core_crystal_nominal_freq
if you add _khz to the name, you could drop the comments.
Done