[coreboot-gerrit] Change in coreboot[master]: mb/asrock/h110m: enable ACPI LDN in SuperIO

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35370 )

Change subject: mb/asrock/h110m: enable ACPI LDN in SuperIO
......................................................................

Patch Set 1:

(1 comment)

Thanks for the review

https://review.coreboot.org/c/coreboot/+/35370/1/src/mainboard/asrock/h110m/... 
File src/mainboard/asrock/h110m/bootblock.c:

https://review.coreboot.org/c/coreboot/+/35370/1/src/mainboard/asrock/h110m/... 
PS1, Line 35: 	pnp_write_config(acpi_dev, 0xe4, 0x70);
> why is it done here and not in devicetree. […]

It seemed to me that this should be in bootblock, as it was done in other boards, before all LDNs are enabled in the device tree. But I suppose I could be wrong