[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: To support ELAN Touchpad device on I2C0

[Alex1 Kao (Code Review)]

Attention is currently required from: Karthik Ramasubramanian.
Alex1 Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52936 )

Change subject: mb/google/dedede: To support ELAN Touchpad device on I2C0
......................................................................

Patch Set 5:

(2 comments)

File src/mainboard/google/dedede/variants/pirika/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/52936/comment/10cc1e2e_18bd89ca 
PS2, Line 21: .speed_config[0] = {
            : 				.speed = I2C_SPEED_FAST,
            : 				.scl_lcnt = 190,
            : 				.scl_hcnt = 100,
            : 				.sda_hold = 40,
            : 			}
> The recommendation is to configure the measured rise_time_ns and fall_time_ns here instead of scl_lc […]

Thanks for your advice. I will create another issue for I2C clock tuning. Now I re-uploaded this CL for support ELAN Touchpad device on I2C0.

https://review.coreboot.org/c/coreboot/+/52936/comment/d0c1f76f_43aa61cb 
PS2, Line 52: 	device domain 0 on
> Prefer to split this CL into 4 parts […]

Got it, thanks.