Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69139 )
Change subject: Revert "soc/mediatek/mt8188: Allow CPUfreq hardware to access MCUPM registers"
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69139/comment/bff1a061_fd3313aa
PS1, Line 11: In this patch, we allow MCUPM to access secure registers and set the
: domain to DOMAIN_2.
nit: Is this about commit a8172c329fe309f3b5b409c1a59a227186400dd4 ? It's a bit confusing: "this patch" could mean CB:69139 (this) or CB:67724 (the reverted commit).
https://review.coreboot.org/c/coreboot/+/69139/comment/7e61c142_32f5e856
PS1, Line 21:
Signed-off-by is missing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d9809f6e84b8d10bc2e6f2ea5a442e676ad3bf9
Gerrit-Change-Number: 69139
Gerrit-PatchSet: 1
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 09:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment