Attention is currently required from: Jason Glenesk, HAOUAS Elyes, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45526 )
Change subject: soc/amd/{picasso,stoneyridge}/romstage.c: Use post_codes macros
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Is a similar change going into other SOCs? For what it's worth, it seems like a more appropriate location for POST_CONSOLE_BOOT_MSG would be in lib/bootblock.c after console_init(). Or potentially in bootblock_soc_init() in the soc directories.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51782996602a4ae17058e6ff85d4e05f751a2bfd
Gerrit-Change-Number: 45526
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 20 Jan 2021 19:10:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment