Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35774 )
Change subject: crossgcc: Upgrade CMake to 3.16.0
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35774/3/util/crossgcc/buildgcc
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/35774/3/util/crossgcc/buildgcc@85
PS3, Line 85: 3.16
I wonder if that should be v${CMAKE_VERSION_MAJMIN} with CMAKE_VERSION_MAJMIN=$(echo ${CMAKE_VERSION} | cut -d. -f-2), but that's something we could do in a follow up commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib564217c4fdcb609fd6dfd4cb71288dd54ffe4bf
Gerrit-Change-Number: 35774
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 13:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment