Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30499 )
Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/Kconfig:
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 15: select BOOTBLOCK_CONSOLE This needs C_ENV_BOOTBLOCK to have any effect?
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/romstage.c:
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 23: #include <cpu/x86/mtrr.h> I don't see why.
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-q35/Kco... File src/mainboard/emulation/qemu-q35/Kconfig:
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-q35/Kco... PS4, Line 14: select BOOTBLOCK_CONSOLE As before.
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-q35/rom... File src/mainboard/emulation/qemu-q35/romstage.c:
https://review.coreboot.org/#/c/30499/4/src/mainboard/emulation/qemu-q35/rom... PS4, Line 24: #include <cpu/x86/mtrr.h> As before.