Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )
Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................
Patch Set 12: Code-Review+2
(1 comment)
I'm curious: where is your list from?
https://review.coreboot.org/#/c/30610/12/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:
https://review.coreboot.org/#/c/30610/12/util/inteltool/inteltool.h@328
PS12, Line 328: #define PCI_DEVICE_ID_INTEL_IRIS_PLUS_655 0x3EA5
If half of them are UHD 630, maybe we shouldn't use
the marketing names? The most elaborate list I know
is in the Linux sources (include/drm/i915_pciids.h),
with a little more distinguished names (less dis-
tinguished in the Iris case, though, *sigh*).
NB. most of this file seems to use lower-case hex
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30610
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I299a5fc082433b0aab4861a24aecbe83b61a404a
Gerrit-Change-Number: 30610
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer
migy@darmstadt.ccc.de
Gerrit-Reviewer: Felix Singer
migy@darmstadt.ccc.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Mar 2019 12:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment