build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32027 )
Change subject: WIP: Make common macros double-evaluation safe ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/32027/5/payloads/libpayload/include/libpaylo... File payloads/libpayload/include/libpayload.h:
https://review.coreboot.org/#/c/32027/5/payloads/libpayload/include/libpaylo... PS5, Line 69: #define __CMP_UNSAFE(a, b, op) ((a) op (b) ? (a) : (b)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32027/5/src/commonlib/include/commonlib/help... File src/commonlib/include/commonlib/helpers.h:
https://review.coreboot.org/#/c/32027/5/src/commonlib/include/commonlib/help... PS5, Line 44: #define __CMP_UNSAFE(a, b, op) ((a) op (b) ? (a) : (b)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/32027/5/src/commonlib/include/commonlib/help... PS5, Line 103: __typeof__(x) _div_local_x = (x); \ line over 80 characters