[coreboot-gerrit] Change in coreboot[master]: drivers/intel/usb4: Add driver for USB4 retimer device

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )

Change subject: drivers/intel/usb4: Add driver for USB4 retimer device
......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... 
File src/drivers/intel/usb4/retimer/retimer.c:

https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... 
PS5, Line 7: device/i2c_simple.h
> Is this required?

I think left over from when I was under the impression the retimer was attached to smbus based on the early documentation.

https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... 
PS5, Line 65: / Read power gpio into Local0
> Why is this required? Can we not simply make a call to enable/disable without looking at the current […]

I don't think it hurts but could probably be skipped.

https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... 
PS5, Line 87: Local0
Hm this and the other one should be local2 I think