Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34497 )
Change subject: mb/google/drallion: Add new mainboard
......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34497/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34497/5//COMMIT_MSG@9
PS5, Line 9: Drallion is a new mainboard using Intel Comet Lake SOC & Wilco EC
Please add a dot at the end of the sentence.
Done
https://review.coreboot.org/c/coreboot/+/34497/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34497/10//COMMIT_MSG@13
PS10, Line 13: BUG=None
: Test=Needs to be tested
Agreed! Done.
Done
https://review.coreboot.org/c/coreboot/+/34497/4/src/mainboard/google/dralli...
File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/34497/4/src/mainboard/google/dralli...
PS4, Line 27: select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_DRALLION
Arcada uses GBE region. […]
Drallion will not have GbE but the test build based on sarien will so lets leave it for now.
https://review.coreboot.org/c/coreboot/+/34497/4/src/mainboard/google/dralli...
File src/mainboard/google/drallion/ramstage.c:
https://review.coreboot.org/c/coreboot/+/34497/4/src/mainboard/google/dralli...
PS4, Line 79: /* Disable unused pads for devices with board ID > 2 */
: if (board_id() > 2)
: gpio_configure_pads(gpio_unused, ARRAY_SIZE(gpio_unused));
For the EV drallion boards we will be using the Arcada and Sarien boards with its SOC replaced by Co […]
I think that this may not be necessary for the final build, but we can leave it for now with the test units.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I541952a4ef337e7277a85f02d25979f12ec075c4
Gerrit-Change-Number: 34497
Gerrit-PatchSet: 11
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 05 Aug 2019 22:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thejaswani Putta
thejaswani.putta@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-MessageType: comment