Attention is currently required from: Scott Chao.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63713 )
Change subject: mb/google/brya/var/crota: update gpio configuration
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63713/comment/263de049_f4930274
PS2, Line 9: enable CPU PCIe VGPIO for PEG60.
: - enable GPP_C3/ GPP_C4 native function.
: - set unused GPIO to NC
Please remove the dots/periods at the end or start the sentences with a capital letter.
https://review.coreboot.org/c/coreboot/+/63713/comment/949fcded_beb16026
PS2, Line 15: kernel
Which version?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d4ef92623ce6b0a36e6df23b232b35b498ce964
Gerrit-Change-Number: 63713
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 20 Apr 2022 05:17:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment