[coreboot-gerrit] Change in coreboot[master]: mb/purism/librem_cnl: Adjust in preparation for new variants

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )

Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants
......................................................................

Patch Set 1:
> personally, I find it much more clear when board specific options are selected in `Kconfig.name`.

erm, you are bringing the argument from the very beginning up again... no, Kconfig.name is not the right place
> I'm aware I could just guard the SoC selection in Kconfig by board, but IMO that gets ugly when you have `select SOC_XXX if BOARD_X || BOARD_Y || BOARD_Z` and then the same for the other SoC

huh? ofc you shouldn't do that. see Angel's example which boils down to a few lines Kconfig in your case