Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40648 )
Change subject: soc/intel/tigerlake: Print HPR_CAUSE0 register and update elog
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40648/3/src/include/elog.h
File src/include/elog.h:
https://review.coreboot.org/c/coreboot/+/40648/3/src/include/elog.h@198
PS3, Line 198: /* ME-Initiated Host Reset */
: #define ELOG_TYPE_MI_HRPD 0xb3
: #define ELOG_TYPE_MI_HRPC 0xb4
: #define ELOG_TYPE_MI_HR 0xb5
Should we create separate patch for this header change?
I meant.
1. elog header change
2. print rst cause and save elog.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc57c3cd6a8d156c5544640898e8e7147d34c535
Gerrit-Change-Number: 40648
Gerrit-PatchSet: 3
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 Apr 2020 08:21:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment