Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34075 )
Change subject: [WIP] include, arch: Unify stdint.h ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34075/4/src/arch/arm/armv7/mmu.c File src/arch/arm/armv7/mmu.c:
https://review.coreboot.org/c/coreboot/+/34075/4/src/arch/arm/armv7/mmu.c@16... PS4, Line 168: printk(BIOS_DEBUG, "Creating new subtable @%p for [%#.8" PRIxPTR ":%#.8" PRIxPTR ")\n", Please stick to the 80 char line length used in the rest of the file until the whole file has been converted to 96. (Why not just change the x to lx? And why is this code affected by this patch at all?)
https://review.coreboot.org/c/coreboot/+/34075/4/src/include/stdint.h File src/include/stdint.h:
https://review.coreboot.org/c/coreboot/+/34075/4/src/include/stdint.h@105 PS4, Line 105: uint8_t Should this be _Bool?
https://review.coreboot.org/c/coreboot/+/34075/4/src/soc/nvidia/tegra210/mmu... File src/soc/nvidia/tegra210/mmu_operations.c:
https://review.coreboot.org/c/coreboot/+/34075/4/src/soc/nvidia/tegra210/mmu... PS4, Line 26: uintptr_t start, end; Why does this need to change? (I agree that it's more appropriate, but I don't think you should mix cleanup with this patch unless necessary. You could split it out into a separate patch if you want.)