EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47640 )
Change subject: drivers/i2c: Add a driver for Semtech SX9324 ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/chip... File src/drivers/i2c/sx9324/chip.h:
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/chip... PS2, Line 12: /* ACPI _HID */ : const char *hid;
I see bindings for 3 HIDs in 5.4 (drivers/iio/proximity/sx932x. […]
We will check the kernel driver in the same time. But now just specific to sx9324.
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/chip... PS2, Line 15: /* Device Name */ : const char *name;
Unused in the driver.
Done
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93... File src/drivers/i2c/sx9324/sx9324.c:
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93... PS2, Line 75: D%03.3X
If we just define "SX93"?
Done