Attention is currently required from: Bao Zheng, Raul Rangel, Martin Roth, Tim Van Patten, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74950 )
Change subject: util/amdfwtool: Consolidate entry line regex pattern ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
SHA is changing because the compressed bootblock (Type 0x62 entry) keeps changing before and after t […]
Digging some more found that the bootblock.elf is diffing in 2 places before and after this change: 1) Head Commit ID 2) Build timestamp
Before: ``` 00149ad0 30 33 20 32 31 3a 35 31 3a 30 31 20 55 54 43 20 |03 21:51:01 UTC | 00149ae0 32 30 32 33 00 00 66 90 34 2e 31 39 2d 31 34 37 |2023..f.4.19-147| 00149af0 38 2d 67 63 63 39 39 31 63 35 38 63 66 2d 64 69 |8-gcc991c58cf-di| ```
After: ``` 00149ad0 30 33 20 32 32 3a 32 34 3a 32 33 20 55 54 43 20 |03 22:24:23 UTC | 00149ae0 32 30 32 33 00 00 66 90 34 2e 31 39 2d 31 34 37 |2023..f.4.19-147| 00149af0 39 2d 67 37 37 34 37 33 36 63 33 34 34 2d 64 69 |9-g774736c344-di| 00149b00 72 74 79 00 44 65 6c 61 79 65 64 20 25 64 20 6d |rty.Delayed %d m| ```
Even when I try `BUILD_TIMELESS=1 util/abuild/abuild -t GOOGLE_GUYBRUSH`, I keep seeing the timestamp is changing. This change in timestamp and commit ID is causing changes in the compressed bootblock output and in turn amdfw.rom