Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46825 )
Change subject: mb/google/volteer: provide gpio-reset interface for Bluetooth reset ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6: Code-Review-1
The usb config is per-variant, this needs to go in overridetree. I have some patches coming to define all the usb ports.
Hi Ducan, gpio-reset using A-13 across all TGL variants. cant we place in baseboard? Overridetree from each platform is must? pls provide the feedback.
The USB port setup is not the same across all variants (it is for BT but not the other ports) so it needs to go in overridetree. as mentioned I have some patches coming to configure the USB ACPI for all variants.
Agreed. Will put this change on override for every variant.