Alexandru Gagniuc (mr.nuke.me@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6985
-gerrit
commit c9cab6fc30d406ce88271a698e2c515e104fe1a3 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Sat Sep 27 10:02:15 2014 +0200
packardbell/ms2290: Fix build with native graphics init
Fix up commit a2a906e4 (Consolidate intel vga int15 hooks) [1] breaking the build of Packard Bell EasyNote LM85 (MS2290) with native graphics initialization enabled.
src/mainboard/packardbell/ms2290/mainboard.c: In function 'mainboard_enable': src/mainboard/packardbell/ms2290/mainboard.c:127:2: error: implicit declaration of function 'install_intel_vga_int15_handler' [-Werror=implicit-function-declaration] src/mainboard/packardbell/ms2290/mainboard.c:127:34: error: 'GMA_INT15_ACTIVE_LFP_INT_LVDS' undeclared (first use in this function) src/mainboard/packardbell/ms2290/mainboard.c:127:34: note: each undeclared identifier is reported only once for each function it appears in src/mainboard/packardbell/ms2290/mainboard.c:127:65: error: 'GMA_INT15_PANEL_FIT_DEFAULT' undeclared (first use in this function) src/mainboard/packardbell/ms2290/mainboard.c:127:94: error: 'GMA_INT15_BOOT_DISPLAY_LFP' undeclared (first use in this function)
Include the header file `drivers/intel/gma/int15.h` unconditionally, so that the prototype of `install_intel_vga_int15_handler()` is always to be found.
[1] http://review.coreboot.org/6820
Change-Id: Ie64f9510f49fe9d67b14ce27d7e789d6007ca0a6 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/mainboard/packardbell/ms2290/mainboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index c14e9b7..9e64f5c 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -35,8 +35,8 @@
#include <pc80/mc146818rtc.h> #include <arch/x86/include/arch/acpigen.h> -#if CONFIG_PCI_OPTION_ROM_RUN_YABEL || CONFIG_PCI_OPTION_ROM_RUN_REALMODE #include <drivers/intel/gma/int15.h> +#if CONFIG_PCI_OPTION_ROM_RUN_YABEL || CONFIG_PCI_OPTION_ROM_RUN_REALMODE #include <arch/interrupt.h> #endif #include <pc80/keyboard.h>