Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )
Change subject: coreboot-id: Add coreboot id based on FMAP entries ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... File src/mainboard/siemens/mc_apl1/mc_apl_vboot.fmd:
https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... PS2, Line 9: COREBOOT_ID 0x40 : RO_FRID_PAD 0x780
Actually, no. The reason I dropped it from Chrome OS boards is because I am confident that we don't use it and we have RO_FRID which already stores similar information. I can add it back if you want all boards to be consistent.
Okay, but... don't you still think that adding it to 100 different FMAP files (and having to subsequently fit it into every future FMAP we'll write) would be a hassle that would be nice to avoid?
Yes, our tooling in this area is not great at all which leads to things being cumbersome. This is obviously my opinion, but I'd like to see us drop C as our tool language and Make doing as many complex things as it does in coreboot. We mad that decision 3 years ago or so about not having better tools in image composition, and I think we keep having issues because of it. Anyway, my $.02. :)
FWIW, I don't think the id thing adds much value, but it's not something *I* use. I haven't seen a lot of complaints from others on this patchset so maybe we just nuke the whole thing?
Thanks for your elaboration, Julius, on the 'clunky and high touch' opinion.