Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37842 )
Change subject: southbridge: Add missing include <device/pci_def.h>
......................................................................
Patch Set 1: Code-Review-2
We have some bigger plans around this topic, the -2 is to get the discussion done first so we do not go back-and-forth with this specific header.
This is technically correct, but I would disagree on having PCI_SLOT() and PCI_DEVFN() et.al. defined in <device/pci_def.h>. IMHO that file should be strictly about definitions dictated by the various PCI standard papers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7295b87ddbbf7a44f099e48a93f40d682b2a888
Gerrit-Change-Number: 37842
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Dec 2019 07:40:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment